summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHenning Schild <henning.schild@siemens.com>2016-07-22 14:46:52 +0200
committerMichal Marek <mmarek@suse.com>2016-07-26 22:26:46 +0200
commitca617dc68b23407c4b7427d4f2fd71e0ba7ba81d (patch)
treedb9e8d109b7262cc70dec63dec3ec2f18fd4aa45
parentcc65e823363834a7ff0a2eca9bef2bbef64135f7 (diff)
builddeb: fix file permissions before packaging
Builddep is not very explicit about file permissions. Actually the file permissions in the package are largely influenced by the umask of the user cloning the git and building the package. If that umask does not set go+r the resulting linux-headers package will prevent non-root users from building out-of-tree modules. And that is probably just one unexpected effect. Being a packaging/install tool builddep should make sure the file permissions are set correctly and not just derived from a value that is never checked. This patch sets ugo read permissions for all packaged files and derives the executable bit for directories and executables from the file-owner. Signed-off-by: Henning Schild <henning.schild@siemens.com> Signed-off-by: Michal Marek <mmarek@suse.com>
-rwxr-xr-xscripts/package/builddeb2
1 files changed, 2 insertions, 0 deletions
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 202d6e7db859..116ef00c0b82 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -26,6 +26,8 @@ create_package() {
# Fix ownership and permissions
chown -R root:root "$pdir"
chmod -R go-w "$pdir"
+ # in case we are in a restrictive umask environment like 0077
+ chmod -R a+rX "$pdir"
# Create the package
dpkg-gencontrol $forcearch -Vkernel:debarch="${debarch}" -p$pname -P"$pdir"