summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQiheng Lin <linqiheng@huawei.com>2022-12-08 21:34:49 +0800
committerMichael Ellerman <mpe@ellerman.id.au>2024-03-03 22:20:28 +1100
commitcda9c0d556283e2d4adaa9960b2dc19b16156bae (patch)
tree80b16af37b595ddeb1df54b5c12349b6e518f8d9
parent6035e7e35482653d6d93f35f01e1a320573d58f0 (diff)
powerpc/pseries: Fix potential memleak in papr_get_attr()
`buf` is allocated in papr_get_attr(), and krealloc() of `buf` could fail. We need to free the original `buf` in the case of failure. Fixes: 3c14b73454cf ("powerpc/pseries: Interface to represent PAPR firmware attributes") Signed-off-by: Qiheng Lin <linqiheng@huawei.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20221208133449.16284-1-linqiheng@huawei.com
-rw-r--r--arch/powerpc/platforms/pseries/papr_platform_attributes.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/arch/powerpc/platforms/pseries/papr_platform_attributes.c b/arch/powerpc/platforms/pseries/papr_platform_attributes.c
index 526c621b098b..eea2041b270b 100644
--- a/arch/powerpc/platforms/pseries/papr_platform_attributes.c
+++ b/arch/powerpc/platforms/pseries/papr_platform_attributes.c
@@ -101,10 +101,12 @@ retry:
esi_buf_size = ESI_HDR_SIZE + (CURR_MAX_ESI_ATTRS * max_esi_attrs);
temp_buf = krealloc(buf, esi_buf_size, GFP_KERNEL);
- if (temp_buf)
+ if (temp_buf) {
buf = temp_buf;
- else
- return -ENOMEM;
+ } else {
+ ret = -ENOMEM;
+ goto out_buf;
+ }
goto retry;
}