summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHaowen Bai <baihaowen@meizu.com>2022-04-21 09:43:13 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-29 15:49:42 +0200
commitcebdc5349fba7ba9a76a756d35997d010cd1aac2 (patch)
tree8cab0598e46c730742783bdbe1762f033fd6aec8
parent4388f887b857de8576a8bf7fefc1202dc7dd10df (diff)
firmware: edd: Remove redundant condition
The logic (!A || (A && B)) is equivalent to (!A || B). so we have to make code clear. Signed-off-by: Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1650505393-19398-1-git-send-email-baihaowen@meizu.com Reviewed-by: Griffin Kroah-Hartman <griffin@kroah.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/firmware/edd.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 69353dd0ea22..5cc238916551 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev)
int i;
for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
- if (!attr->test ||
- (attr->test && attr->test(edev)))
+ if (!attr->test || attr->test(edev))
error = sysfs_create_file(&edev->kobj,&attr->attr);
}