diff options
| author | Gabor Juhos <j4g8y7@gmail.com> | 2025-03-13 19:31:21 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-03-16 23:34:25 +0000 |
| commit | d450cdd9c4398add1f2aa7200f2c95f1e3b9f9fa (patch) | |
| tree | 88008938106b37221adeb5e175157bc03eb9c61b | |
| parent | 5a5fc308418aca275a898d638bc38c093d101855 (diff) | |
spi: spi-qpic-snand: avoid memleak in qcom_spi_ecc_init_ctx_pipelined()
When the allocation of the OOB buffer fails, the
qcom_spi_ecc_init_ctx_pipelined() function returns without freeing
the memory allocated for 'ecc_cfg' thus it can cause a memory leak.
Call kfree() to free 'ecc_cfg' before returning from the function
to avoid that.
Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://patch.msgid.link/20250313-qpic-snand-memleak-fix-v1-1-e54e78d1da3a@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-qpic-snand.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index ffb2b6ec685c..fbba7741a9bf 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -263,8 +263,10 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand) return -ENOMEM; snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize, GFP_KERNEL); - if (!snandc->qspi->oob_buf) + if (!snandc->qspi->oob_buf) { + kfree(ecc_cfg); return -ENOMEM; + } memset(snandc->qspi->oob_buf, 0xff, mtd->writesize + mtd->oobsize); |