diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2023-10-30 00:08:36 -0700 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2023-10-31 18:30:16 +0100 |
| commit | dc6e08b1a2ae262c23e14f5c259b4ca63a554e4f (patch) | |
| tree | b6c52f18a74ba1e10aafa7dfce07781f1ad91c8d | |
| parent | 2dc15ff73b6a7b47db0e848498cb5b0479e781c6 (diff) | |
ALSA: hda: cs35l41: Fix missing error code in cs35l41_smart_amp()
When firmware status is invalid, assign -EINVAL to ret as ret is '0' at
that point and returning success is incorrect when firmware status is
invalid.
Fixes: a51d8ba03a4f ("ALSA: hda: cs35l41: Check CSPL state after loading firmware")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20231030070836.3234385-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/hda/cs35l41_hda.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index 98a5123e9f50..b2db8091f0ed 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -1042,6 +1042,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41) default: dev_err(cs35l41->dev, "Firmware status is invalid: %u\n", fw_status); + ret = -EINVAL; goto clean_dsp; } |