diff options
| author | Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2021-06-01 19:09:03 +0800 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2021-07-12 10:30:07 +0200 |
| commit | e642197562cd9781453f835e1406cfe0feeb917e (patch) | |
| tree | 0bbac5bf84010dd494e3830417fb60460fc72316 | |
| parent | 51f3b2c3d511c7753f039176bbce08e8d53a0845 (diff) | |
leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.
Eliminate the follow smatch warning:
drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
error code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
Acked-by: David Rivshin <drivshin@allworx.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
| -rw-r--r-- | drivers/leds/leds-is31fl32xx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 3b55af9a8c58..22c092a4394a 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -386,6 +386,7 @@ static int is31fl32xx_parse_dt(struct device *dev, dev_err(dev, "Node %pOF 'reg' conflicts with another LED\n", child); + ret = -EINVAL; goto err; } |