diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2022-11-11 09:20:44 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-11-14 11:21:02 +0000 |
| commit | f7c125bd79f50ec6094761090be81d02726ec6f4 (patch) | |
| tree | 4482b5032e662be73c61f6c43319e6ba834a989d | |
| parent | 3738d48b9b23f80a90f5de3ebeb0f044f80e9296 (diff) | |
net: mhi: Fix memory leak in mhi_net_dellink()
MHI driver registers network device without setting the
needs_free_netdev flag, and does NOT call free_netdev() when
unregisters network device, which causes a memory leak.
This patch calls free_netdev() to fix it since netdev_priv
is used after unregister.
Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/mhi_net.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c index 0b1b6f650104..0b9d37979133 100644 --- a/drivers/net/mhi_net.c +++ b/drivers/net/mhi_net.c @@ -343,6 +343,8 @@ static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev) kfree_skb(mhi_netdev->skbagg_head); + free_netdev(ndev); + dev_set_drvdata(&mhi_dev->dev, NULL); } |