summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-12-12 15:47:37 +0300
committerDave Stevenson <dave.stevenson@raspberrypi.com>2024-12-12 14:37:30 +0000
commitfcf15fd8ed88507ac618fb9228423edcc99b13ad (patch)
tree7813d4d054b56634ff0805b2f84c6a687bd43611
parentbc0e01b53614d3d6bb80c7b97ab26a609ba394e9 (diff)
drm/vc4: unlock on error in vc4_hvs_get_fifo_frame_count()
The default statement is never used in real life. However, if it were used for some reason then call drm_dev_exit() before returning. Fixes: 8f2fc64773be ("drm/vc4: Fix reading of frame count on GEN5 / Pi4") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Link: https://patchwork.freedesktop.org/patch/msgid/b61a81b2-0101-43bd-a4f6-09cf3a016484@stanley.mountain Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
-rw-r--r--drivers/gpu/drm/vc4/vc4_hvs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c
index b42027636c71..4811d794001f 100644
--- a/drivers/gpu/drm/vc4/vc4_hvs.c
+++ b/drivers/gpu/drm/vc4/vc4_hvs.c
@@ -522,7 +522,7 @@ u8 vc4_hvs_get_fifo_frame_count(struct vc4_hvs *hvs, unsigned int fifo)
break;
default:
drm_err(drm, "Unknown VC4 generation: %d", vc4->gen);
- return 0;
+ break;
}
drm_dev_exit(idx);