diff options
author | Trevor Wu <trevor.wu@mediatek.com> | 2023-02-02 18:37:04 +0800 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2023-02-03 12:03:57 +0000 |
commit | 66b9e94cb7783d3c632e2c1b436b26ece8c14e5d (patch) | |
tree | d44c1b8f4ff0295407cd1763ea3e591879787857 /Documentation/devicetree/bindings/sound/component-common.yaml | |
parent | 218674a45930c700486d27b765bf2f1b43f8cbf7 (diff) |
ASoC: mediatek: mt8188: remove etdm dead code
Some Smatch static checker warning like below was found.
sound/soc/mediatek/mt8188/mt8188-dai-etdm.c:2487
mt8188_dai_etdm_parse_of()
warn: 'ret' returned from snprintf() might be larger than 48
2479 for (i = 0; i < MT8188_AFE_IO_ETDM_NUM; i++) {
2480 dai_id = ETDM_TO_DAI_ID(i);
2481 etdm_data = afe_priv->dai_priv[dai_id];
2482
2483 ret = snprintf(prop, sizeof(prop),
2484 "mediatek,%s-multi-pin-mode",
2485 of_afe_etdms[i].name);
2486 if (ret < 0) {
--> 2487 dev_err(afe->dev, "%s snprintf
err=%d\n",
2488
In linux kernel, snprintf() never returns negatives. On the other hand,
the format string like "mediatek,%s-multi-pin-mode" must be smaller
than sizeof(prop)=48.
After discussing in the mail thread[1], I remove the dead code to fix
the Smatch warnings.
[1]: https://lore.kernel.org/all/Y9EdBg641tJDDrt%2F@kili/
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://lore.kernel.org/r/20230202103704.15626-1-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'Documentation/devicetree/bindings/sound/component-common.yaml')
0 files changed, 0 insertions, 0 deletions