diff options
| author | Richard Fitzgerald <rf@opensource.cirrus.com> | 2024-07-02 12:08:09 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-07-02 13:59:35 +0100 |
| commit | 62412a9357b16a4e39dc582deb2e2a682b92524c (patch) | |
| tree | 2108fde9c13b61c620ab13e97fbe5e208598d956 /Documentation/devicetree/bindings/sound | |
| parent | a893a804c6bb09336a217780c722b7d1c88357c6 (diff) | |
firmware: cs_dsp: Don't allow writes to read-only controls
Add a check to cs_dsp_coeff_write_ctrl() to abort if the control
is not writeable.
The cs_dsp code originated as an ASoC driver (wm_adsp) where all
controls were exported as ALSA controls. It relied on ALSA to
enforce the read-only permission. Now that the code has been
separated from ALSA/ASoC it must perform its own permission check.
This isn't currently causing any problems so there shouldn't be any
need to backport this. If the client of cs_dsp exposes the control as
an ALSA control, it should set permissions on that ALSA control to
protect it. The few uses of cs_dsp_coeff_write_ctrl() inside drivers
are for writable controls.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20240702110809.16836-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'Documentation/devicetree/bindings/sound')
0 files changed, 0 insertions, 0 deletions