summaryrefslogtreecommitdiff
path: root/Documentation/kbuild/kbuild.rst
diff options
context:
space:
mode:
authorYuan Can <yuancan@huawei.com>2022-11-10 02:00:30 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-01-20 12:05:26 +0100
commitd717a3ab282f51ec45142f911f7ef8a55c057de5 (patch)
tree508d6f0960eab2782f42e4aeaa7d6d4ff39a13f4 /Documentation/kbuild/kbuild.rst
parent0eb468b6e1c56b55c01bfc588f9a519ac15b4ff5 (diff)
eeprom: idt_89hpesx: Fix error handling in idt_init()
A problem about idt_89hpesx create debugfs failed is triggered with the following log given: [ 4973.269647] debugfs: Directory 'idt_csr' with parent '/' already present! The reason is that idt_init() returns i2c_add_driver() directly without checking its return value, if i2c_add_driver() failed, it returns without destroy the newly created debugfs, resulting the debugfs of idt_csr can never be created later. idt_init() debugfs_create_dir() # create debugfs directory i2c_add_driver() driver_register() bus_add_driver() priv = kzalloc(...) # OOM happened # return without destroy debugfs directory Fix by removing debugfs when i2c_add_driver() returns error. Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") Signed-off-by: Yuan Can <yuancan@huawei.com> Acked-by: Serge Semin <fancer.lancer@gmail.com> Link: https://lore.kernel.org/r/20221110020030.47711-1-yuancan@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/kbuild/kbuild.rst')
0 files changed, 0 insertions, 0 deletions