diff options
author | Yuntao Wang <yuntao.wang@linux.dev> | 2024-08-13 09:48:27 +0800 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2024-08-13 15:15:19 +0200 |
commit | 0ecc5be200c84e67114f3640064ba2bae3ba2f5a (patch) | |
tree | 7e45cbb9c5c7e74f4578850f2bf47c7c0c8f9644 /crypto/twofish_common.c | |
parent | 7c626ce4bae1ac14f60076d00eafe71af30450ba (diff) |
x86/apic: Make x2apic_disable() work correctly
x2apic_disable() clears x2apic_state and x2apic_mode unconditionally, even
when the state is X2APIC_ON_LOCKED, which prevents the kernel to disable
it thereby creating inconsistent state.
Due to the early state check for X2APIC_ON, the code path which warns about
a locked X2APIC cannot be reached.
Test for state < X2APIC_ON instead and move the clearing of the state and
mode variables to the place which actually disables X2APIC.
[ tglx: Massaged change log. Added Fixes tag. Moved clearing so it's at the
right place for back ports ]
Fixes: a57e456a7b28 ("x86/apic: Fix fallout from x2apic cleanup")
Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20240813014827.895381-1-yuntao.wang@linux.dev
Diffstat (limited to 'crypto/twofish_common.c')
0 files changed, 0 insertions, 0 deletions