diff options
| author | Matthew Auld <matthew.auld@intel.com> | 2024-09-23 15:56:48 +0100 |
|---|---|---|
| committer | Matthew Auld <matthew.auld@intel.com> | 2024-09-26 14:30:30 +0100 |
| commit | 861108666cc0e999cffeab6aff17b662e68774e3 (patch) | |
| tree | cffe863328eccc703ed4d78bae2fb53cf44aa6ed /drivers/android/binder_trace.h | |
| parent | d28af0b6b9580b9f90c265a7da0315b0ad20bbfd (diff) | |
drm/xe: fix UAF around queue destruction
We currently do stuff like queuing the final destruction step on a
random system wq, which will outlive the driver instance. With bad
timing we can teardown the driver with one or more work workqueue still
being alive leading to various UAF splats. Add a fini step to ensure
user queues are properly torn down. At this point GuC should already be
nuked so queue itself should no longer be referenced from hw pov.
v2 (Matt B)
- Looks much safer to use a waitqueue and then just wait for the
xa_array to become empty before triggering the drain.
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2317
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org> # v6.8+
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240923145647.77707-2-matthew.auld@intel.com
Diffstat (limited to 'drivers/android/binder_trace.h')
0 files changed, 0 insertions, 0 deletions