diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2025-01-14 11:15:19 +0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2025-01-19 12:44:28 +0800 |
| commit | 9d4f8e54cef2c42e23ef258833dbd06a1eaff89b (patch) | |
| tree | c615255a7203eb9b9e3cca1fd3f6cd2b33322244 /drivers/crypto/bcm/spu.c | |
| parent | 076d9119cc3292c20524ceeecfbed9b3e9c7221b (diff) | |
rhashtable: Fix rhashtable_try_insert test
The test on whether rhashtable_insert_one did an insertion relies
on the value returned by rhashtable_lookup_one. Unfortunately that
value is overwritten after rhashtable_insert_one returns. Fix this
by moving the test before data gets overwritten.
Simplify the test as only data == NULL matters.
Finally move atomic_inc back within the lock as otherwise it may
be reordered with the atomic_dec on the removal side, potentially
leading to an underflow.
Reported-by: Michael Kelley <mhklinux@outlook.com>
Fixes: e1d3422c95f0 ("rhashtable: Fix potential deadlock by moving schedule_work outside lock")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Michael Kelley <mhklinux@outlook.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
Tested-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/bcm/spu.c')
0 files changed, 0 insertions, 0 deletions