diff options
| author | Christian Brauner <brauner@kernel.org> | 2024-11-25 15:10:04 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-02 11:25:10 +0100 |
| commit | 25fe3d58e4ba20b1ec98d7ce9067ddd234e8e448 (patch) | |
| tree | 7c741d6353bd723d598ac0d86906b89754a435ba /drivers/crypto/ccp/sev-dev.c | |
| parent | 7915f42453602697b402d8cbbeb7689166fb569b (diff) | |
sev-dev: avoid pointless cred reference count bump
and fix a memory leak while at it. The new creds are created via
prepare_creds() and then reverted via put_cred(revert_creds()). The
additional reference count bump from override_creds() wasn't even taken
into account before.
Link: https://lore.kernel.org/r/20241125-work-cred-v2-8-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'drivers/crypto/ccp/sev-dev.c')
| -rw-r--r-- | drivers/crypto/ccp/sev-dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 187c34b02442..2e87ca0e292a 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -244,7 +244,7 @@ static struct file *open_file_as_root(const char *filename, int flags, umode_t m if (!cred) return ERR_PTR(-ENOMEM); cred->fsuid = GLOBAL_ROOT_UID; - old_cred = override_creds(get_new_cred(cred)); + old_cred = override_creds(cred); fp = file_open_root(&root, filename, flags, mode); path_put(&root); |