diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2019-10-17 18:13:52 +0200 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2019-10-17 21:51:51 +0100 |
| commit | 1dfffa0051eae890ce36924651ecff60df5d779e (patch) | |
| tree | 16ec0a7a56f328c8fe7ebd1719cd93e6898046d0 /drivers/gpu/drm/i915/gem | |
| parent | e9768bfe875f1c54d70d5a512e734993996513a5 (diff) | |
drm/i915: Don't disable interrupts independently of the lock
The locks (active.lock and rq->lock) need to be taken with disabled
interrupts. This is done in i915_request_retire() by disabling the
interrupts independently of the locks itself.
While local_irq_disable()+spin_lock() equals spin_lock_irq() on vanilla
it does not on PREEMPT_RT.
Chris Wilson confirmed that local_irq_disable() was just introduced as
an optimisation to avoid enabling/disabling interrupts during
lock/unlock combo.
Enable/disable interrupts as part of the locking instruction.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20191017161352.e5z3ugse7gxl5ari@linutronix.de
Diffstat (limited to 'drivers/gpu/drm/i915/gem')
0 files changed, 0 insertions, 0 deletions