diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2020-12-07 13:03:46 +0000 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2020-12-07 14:36:44 +0000 |
| commit | 4f963d363af57fa4deaaea9b1f34f135b94884e1 (patch) | |
| tree | ee7276400df638162d092a4a29039a4d085479e4 /drivers/gpu/drm/i915/selftests | |
| parent | e70956a2498dc81d8f2522cba074f55ae910e13c (diff) | |
drm/i915/selftests: Improve error reporting for igt_mock_max_segment
When we fail to find a single block large enough to require splitting,
report the largest block we did find.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201207130346.11849-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/selftests')
| -rw-r--r-- | drivers/gpu/drm/i915/selftests/intel_memory_region.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c index a0b518c255de..a55079a061dd 100644 --- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c +++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c @@ -384,16 +384,15 @@ static int igt_mock_max_segment(void *arg) goto out_put; } - err = -EINVAL; + size = 0; list_for_each_entry(block, &obj->mm.blocks, link) { - if (i915_buddy_block_size(&mem->mm, block) > max_segment) { - err = 0; - break; - } + if (i915_buddy_block_size(&mem->mm, block) > size) + size = i915_buddy_block_size(&mem->mm, block); } - if (err) { - pr_err("%s: Failed to create a huge contiguous block\n", - __func__); + if (size < max_segment) { + pr_err("%s: Failed to create a huge contiguous block [> %u], largest block %lld\n", + __func__, max_segment, size); + err = -EINVAL; goto out_close; } |