summaryrefslogtreecommitdiff
path: root/drivers/hwmon/ads1015.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-07-30 11:13:52 +0800
committerGuenter Roeck <linux@roeck-us.net>2014-07-29 20:27:10 -0700
commit56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf (patch)
treed9414641d0cbdf68b54bdf638f4958731fcef8c8 /drivers/hwmon/ads1015.c
parent64aa90f26c06e1cb2aacfb98a7d0eccfbd6c1a91 (diff)
hwmon: (ads1015) Fix off-by-one for valid channel index checking
Current code uses channel as array index, so the valid channel value is 0 .. ADS1015_CHANNELS - 1. Signed-off-by: Axel Lin <axel.lin@ingics.com> Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/ads1015.c')
-rw-r--r--drivers/hwmon/ads1015.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
index 7f9dc2f86b63..22e0c926989d 100644
--- a/drivers/hwmon/ads1015.c
+++ b/drivers/hwmon/ads1015.c
@@ -198,7 +198,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client)
}
channel = be32_to_cpup(property);
- if (channel > ADS1015_CHANNELS) {
+ if (channel >= ADS1015_CHANNELS) {
dev_err(&client->dev,
"invalid channel index %d on %s\n",
channel, node->full_name);