summaryrefslogtreecommitdiff
path: root/drivers/iio/pressure
diff options
context:
space:
mode:
authorDenis Ciocca <denis.ciocca@st.com>2019-08-05 11:57:11 -0700
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2019-08-11 09:26:04 +0100
commite031d5f558f1535968df1ecae8d734b84c17f78d (patch)
tree663fb1b5ab579c6486d387e5dabe3ab747535e86 /drivers/iio/pressure
parent854da7511a05c9a05a4f28fb2225349380520b96 (diff)
iio:st_sensors: remove buffer allocation at each buffer enable
This patch is removing the buffer allocation at each buffer enable. We just allocate enough memory in the main structure during probe to cover maximum size needed (that anyway is pretty small) [16bytes]. Signed-off-by: Denis Ciocca <denis.ciocca@st.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/pressure')
-rw-r--r--drivers/iio/pressure/st_pressure_buffer.c12
1 files changed, 1 insertions, 11 deletions
diff --git a/drivers/iio/pressure/st_pressure_buffer.c b/drivers/iio/pressure/st_pressure_buffer.c
index 77cb2d862f19..418dbf9e6e1e 100644
--- a/drivers/iio/pressure/st_pressure_buffer.c
+++ b/drivers/iio/pressure/st_pressure_buffer.c
@@ -31,17 +31,11 @@ int st_press_trig_set_state(struct iio_trigger *trig, bool state)
static int st_press_buffer_postenable(struct iio_dev *indio_dev)
{
- struct st_sensor_data *press_data = iio_priv(indio_dev);
int err;
- press_data->buffer_data = kmalloc(indio_dev->scan_bytes,
- GFP_DMA | GFP_KERNEL);
- if (!press_data->buffer_data)
- return -ENOMEM;
-
err = iio_triggered_buffer_postenable(indio_dev);
if (err < 0)
- goto st_press_free_buffer;
+ return err;
err = st_sensors_set_enable(indio_dev, true);
if (err < 0)
@@ -51,14 +45,11 @@ static int st_press_buffer_postenable(struct iio_dev *indio_dev)
st_press_buffer_predisable:
iio_triggered_buffer_predisable(indio_dev);
-st_press_free_buffer:
- kfree(press_data->buffer_data);
return err;
}
static int st_press_buffer_predisable(struct iio_dev *indio_dev)
{
- struct st_sensor_data *press_data = iio_priv(indio_dev);
int err, err2;
err = st_sensors_set_enable(indio_dev, false);
@@ -67,7 +58,6 @@ static int st_press_buffer_predisable(struct iio_dev *indio_dev)
if (!err)
err = err2;
- kfree(press_data->buffer_data);
return err;
}