diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2023-10-24 08:38:15 +0800 |
|---|---|---|
| committer | Leon Romanovsky <leon@kernel.org> | 2023-10-24 18:16:04 +0300 |
| commit | 7a1c2abf9a2be7d969b25e8d65567933335ca88e (patch) | |
| tree | 6c14c7286e8d5f8a4d937b913cf77fb271027fb3 /drivers/infiniband/core/nldev.c | |
| parent | b55706366c5ed63749186f22bfb0a15a1de7c074 (diff) | |
RDMA/core: Remove NULL check before dev_{put, hold}
The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warning:
./drivers/infiniband/core/nldev.c:375:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7047
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20231024003815.89742-1-yang.lee@linux.alibaba.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/infiniband/core/nldev.c')
| -rw-r--r-- | drivers/infiniband/core/nldev.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index 5c805fa6187f..43d648a6b6e5 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -371,8 +371,7 @@ static int fill_port_info(struct sk_buff *msg, } out: - if (netdev) - dev_put(netdev); + dev_put(netdev); return ret; } |