summaryrefslogtreecommitdiff
path: root/drivers/input/touchscreen
diff options
context:
space:
mode:
authorFlorian Vaussard <florian.vaussard@gmail.com>2016-11-29 17:39:25 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2016-11-30 09:03:45 -0800
commit6473bbfd7e85a9f834ed668b4daa31638c73ff53 (patch)
treefc093d6d252c937e551285ab2d193c0aec40c357 /drivers/input/touchscreen
parent037b3af6bf84a404a8c6dbe0a7dd551f1b95b530 (diff)
Input: drv2667 - fix misuse of regmap_update_bits
Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform (mask & 1), which results in 0 if LSB of mask is 0. Thus the call regmap_update_bits(..., mask, 1) is in reality equivalent to regmap_update_bits(..., mask, 0). In such a case, the correct use is regmap_update_bits(..., mask, mask). This driver is performing such a mistake with the DRV2667_STANDBY mask, which equals (1 << 6). Fix the driver to make it consistent with the API, and fix the alignment problem at the same time. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/touchscreen')
0 files changed, 0 insertions, 0 deletions