diff options
| author | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-05-13 14:09:25 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-05-13 14:12:05 -0300 |
| commit | 45f38cb3b80311ade3c87000f7d7a8f6ebd60a43 (patch) | |
| tree | 002524371b81008a600eaabb17c39e477ba385dd /drivers/media/pci/saa7134/saa7134-i2c.c | |
| parent | 2bb3e2eec50c4cc7e0aefc4ef4cc9a1c371038ae (diff) | |
[media] saa7134: avoid complex macro warnings
The debug macros are not properly defined, as they generate warnings
like:
ERROR: Macros with complex values should be enclosed in parentheses
+#define core_dbg(fmt, arg...) if (core_debug) \
+ printk(KERN_DEBUG pr_fmt("core: " fmt), ## arg)
Use do { } while (0) for those macros.
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/pci/saa7134/saa7134-i2c.c')
| -rw-r--r-- | drivers/media/pci/saa7134/saa7134-i2c.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/drivers/media/pci/saa7134/saa7134-i2c.c b/drivers/media/pci/saa7134/saa7134-i2c.c index d04fbdb49158..b90434b41efe 100644 --- a/drivers/media/pci/saa7134/saa7134-i2c.c +++ b/drivers/media/pci/saa7134/saa7134-i2c.c @@ -41,11 +41,15 @@ static unsigned int i2c_scan; module_param(i2c_scan, int, 0444); MODULE_PARM_DESC(i2c_scan,"scan i2c bus at insmod time"); -#define i2c_dbg(level, fmt, arg...) if (i2c_debug == level) \ - printk(KERN_DEBUG pr_fmt("i2c: " fmt), ## arg) - -#define i2c_cont(level, fmt, arg...) if (i2c_debug == level) \ - pr_cont(fmt, ## arg) +#define i2c_dbg(level, fmt, arg...) do { \ + if (i2c_debug == level) \ + printk(KERN_DEBUG pr_fmt("i2c: " fmt), ## arg); \ + } while (0) + +#define i2c_cont(level, fmt, arg...) do { \ + if (i2c_debug == level) \ + pr_cont(fmt, ## arg); \ + } while (0) #define I2C_WAIT_DELAY 32 #define I2C_WAIT_RETRY 16 |