summaryrefslogtreecommitdiff
path: root/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
diff options
context:
space:
mode:
authorZhang Changzhong <zhangchangzhong@huawei.com>2020-12-04 09:29:34 +0100
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2021-01-12 18:12:51 +0100
commit4397efebf039be58e98c81a194a26100eba597bb (patch)
tree5468b519314311023be5983c6b2df440136875e0 /drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
parentd7a7d721064c548042b019cd0d4d62e0bb878d71 (diff)
media: mtk-vcodec: fix error return code in vdec_vp9_decode()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: dea42fb79f4f ("media: mtk-vcodec: reset segment data then trig decoder") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c')
-rw-r--r--drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c b/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
index 5ea153a68522..d9880210b2ab 100644
--- a/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
+++ b/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
@@ -890,7 +890,8 @@ static int vdec_vp9_decode(void *h_vdec, struct mtk_vcodec_mem *bs,
memset(inst->seg_id_buf.va, 0, inst->seg_id_buf.size);
if (vsi->show_frame & BIT(2)) {
- if (vpu_dec_start(&inst->vpu, NULL, 0)) {
+ ret = vpu_dec_start(&inst->vpu, NULL, 0);
+ if (ret) {
mtk_vcodec_err(inst, "vpu trig decoder failed");
goto DECODE_ERROR;
}