diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-03-07 12:30:16 +0300 |
|---|---|---|
| committer | Hans Verkuil <hverkuil@xs4all.nl> | 2025-03-07 11:02:16 +0100 |
| commit | ca8dc5951b6be04bb6e2b69a1606c8fbaa5e4fb4 (patch) | |
| tree | c476e713c824a809ce64e19d75ca39b7272c052b /drivers/media/platform | |
| parent | fae8cab4ba3a76bb883eca176bc442eb5e6d581e (diff) | |
media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
The num_clks is set this way:
hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
if (hdmirx_dev->num_clks < 1)
return -ENODEV;
The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.
Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Diffstat (limited to 'drivers/media/platform')
| -rw-r--r-- | drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c index e4cdd8b5745d..3d2913de9a86 100644 --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c @@ -151,7 +151,7 @@ struct snps_hdmirx_dev { bool hpd_trigger_level_high; bool tmds_clk_ratio; bool plugged; - u32 num_clks; + int num_clks; u32 edid_blocks_written; u32 cur_fmt_fourcc; u32 color_depth; |