summaryrefslogtreecommitdiff
path: root/drivers/media
diff options
context:
space:
mode:
authorYassine Oudjana <y.oudjana@protonmail.com>2023-05-03 08:53:40 +0100
committerMauro Carvalho Chehab <mchehab@kernel.org>2023-05-26 10:47:30 +0100
commit76743b29f4802afdf81d7ff1228c11e697850235 (patch)
tree231a4df69ca0afb31885e1aaa91fa86e3b2f8e3b /drivers/media
parent14b4bd01f8e5d663a41ef8cec5857db874b66e88 (diff)
media: camss: camss-video: Don't zero subdev format again after initialization
In an earlier commit, setting the which field of the subdev format struct in video_get_subdev_format was moved to a designated initializer that also zeroes all other fields. However, the memset call that was zeroing the fields earlier was left in place, causing the which field to be cleared after being set in the initializer. Remove the memset call from video_get_subdev_format to avoid clearing the initialized which field. Fixes: ecefa105cc44 ("media: Zero-initialize all structures passed to subdev pad operations") Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Tested-by: Andrey Konovalov <andrey.konovalov@linaro.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/platform/qcom/camss/camss-video.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c
index 898f32177b12..8640db306026 100644
--- a/drivers/media/platform/qcom/camss/camss-video.c
+++ b/drivers/media/platform/qcom/camss/camss-video.c
@@ -353,7 +353,6 @@ static int video_get_subdev_format(struct camss_video *video,
if (subdev == NULL)
return -EPIPE;
- memset(&fmt, 0, sizeof(fmt));
fmt.pad = pad;
ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);