diff options
| author | Oleksij Rempel <o.rempel@pengutronix.de> | 2023-02-11 08:41:09 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-02-13 11:12:31 +0000 |
| commit | 022c3f87f88e2d68e90be7687d981c9cb893a3b1 (patch) | |
| tree | fc262dd87f60a5a73f44c535fcb49ff7ca67bb53 /drivers/net/phy/phy_device.c | |
| parent | cf9f6079696840093aa6ea3c0ee405a553afe2fb (diff) | |
net: phy: add genphy_c45_ethtool_get/set_eee() support
Add replacement for phy_ethtool_get/set_eee() functions.
Current phy_ethtool_get/set_eee() implementation is great and it is
possible to make it even better:
- this functionality is for devices implementing parts of IEEE 802.3
specification beyond Clause 22. The better place for this code is
phy-c45.c
- currently it is able to do read/write operations on PHYs with
different abilities to not existing registers. It is better to
use stored supported_eee abilities to avoid false read/write
operations.
- the eee_active detection will provide wrong results on not supported
link modes. It is better to validate speed/duplex properties against
supported EEE link modes.
- it is able to support only limited amount of link modes. We have more
EEE link modes...
By refactoring this code I address most of this point except of the last
one. Adding additional EEE link modes will need more work.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy_device.c')
0 files changed, 0 insertions, 0 deletions