diff options
| author | Zekun Shen <bruceshenzk@gmail.com> | 2021-01-11 19:49:29 +0200 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2021-01-18 18:11:32 +0200 |
| commit | d18ba9f1351c4675948c87e33a571d28c97d53a7 (patch) | |
| tree | a90a8a60032d077a0b5cdaa7908c76deb911f190 /drivers/net/wireless/ath/ath10k/htc.c | |
| parent | dc5771dfb27d6da7c8d866a358ff5c86e95f06c6 (diff) | |
ath10k: sanitity check for ep connectivity
Function ep_rx_complete is being called without NULL checking
in ath10k_htc_rx_completion_handler. Without such check, mal-
formed packet is able to cause jump to NULL.
ep->service_id seems a good candidate for sanity check as it is
used in usb.c.
Signed-off-by: Zekun Shen <bruceshenzk@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200622022055.16028-1-bruceshenzk@gmail.com
Diffstat (limited to 'drivers/net/wireless/ath/ath10k/htc.c')
| -rw-r--r-- | drivers/net/wireless/ath/ath10k/htc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 31df6dd04bf6..0a37be6a7d33 100644 --- a/drivers/net/wireless/ath/ath10k/htc.c +++ b/drivers/net/wireless/ath/ath10k/htc.c @@ -449,6 +449,10 @@ void ath10k_htc_rx_completion_handler(struct ath10k *ar, struct sk_buff *skb) } ep = &htc->endpoint[eid]; + if (ep->service_id == ATH10K_HTC_SVC_ID_UNUSED) { + ath10k_warn(ar, "htc rx endpoint %d is not connected\n", eid); + goto out; + } payload_len = __le16_to_cpu(hdr->len); |