diff options
| author | Shang XiaoJing <shangxiaojing@huawei.com> | 2022-09-27 10:45:11 +0800 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2022-09-29 09:37:40 +0200 |
| commit | 6db239f01abc7e04a9bc2a0c59c1db1c1ebf9eb3 (patch) | |
| tree | c1c3b3f6dd33d726672cf7cfb6bcd3c0ef9ebefc /drivers/net/wwan/wwan_hwsim.c | |
| parent | 85e69a7dd693667b3e3114713d61edef7552ca88 (diff) | |
wwan_hwsim: Use skb_put_data() instead of skb_put/memcpy pair
Use skb_put_data() instead of skb_put() and memcpy(), which is clear.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20220927024511.14665-1-shangxiaojing@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/wwan/wwan_hwsim.c')
| -rw-r--r-- | drivers/net/wwan/wwan_hwsim.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/wwan/wwan_hwsim.c b/drivers/net/wwan/wwan_hwsim.c index fad642f9ffd8..ff09a8cedf93 100644 --- a/drivers/net/wwan/wwan_hwsim.c +++ b/drivers/net/wwan/wwan_hwsim.c @@ -157,8 +157,8 @@ static int wwan_hwsim_port_tx(struct wwan_port *wport, struct sk_buff *in) if ((i + 1) < in->len && in->data[i + 1] == '\n') i++; n = i - s + 1; - memcpy(skb_put(out, n), &in->data[s], n);/* Echo */ - memcpy(skb_put(out, 6), "\r\nOK\r\n", 6); + skb_put_data(out, &in->data[s], n);/* Echo */ + skb_put_data(out, "\r\nOK\r\n", 6); s = i + 1; port->pstate = AT_PARSER_WAIT_A; } else if (port->pstate == AT_PARSER_SKIP_LINE) { @@ -171,7 +171,7 @@ static int wwan_hwsim_port_tx(struct wwan_port *wport, struct sk_buff *in) if (i > s) { /* Echo the processed portion of a not yet completed command */ n = i - s; - memcpy(skb_put(out, n), &in->data[s], n); + skb_put_data(out, &in->data[s], n); } consume_skb(in); |