summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorDheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>2024-11-17 22:20:28 +0100
committerJakub Kicinski <kuba@kernel.org>2024-11-18 19:32:27 -0800
commitc1822fb64f678ba5bf04dff2bea361537c6f7278 (patch)
treed550e700a4d0e714ce8eb74436ee523e30e4c738 /drivers/net
parent2c862914fbcf85609147401ea8674ae9a9e3b8cc (diff)
wireguard: allowedips: remove redundant selftest call
This commit fixes a useless call issue detected by Coverity (CID 1508092). The call to horrible_allowedips_lookup_v4 is unnecessary as its return value is never checked. Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com> Fixes: e7096c131e51 ("net: WireGuard secure network tunnel") Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Link: https://patch.msgid.link/20241117212030.629159-3-Jason@zx2c4.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireguard/selftest/allowedips.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/wireguard/selftest/allowedips.c b/drivers/net/wireguard/selftest/allowedips.c
index 3d1f64ff2e12..25de7058701a 100644
--- a/drivers/net/wireguard/selftest/allowedips.c
+++ b/drivers/net/wireguard/selftest/allowedips.c
@@ -383,7 +383,6 @@ static __init bool randomized_test(void)
for (i = 0; i < NUM_QUERIES; ++i) {
get_random_bytes(ip, 4);
if (lookup(t.root4, 32, ip) != horrible_allowedips_lookup_v4(&h, (struct in_addr *)ip)) {
- horrible_allowedips_lookup_v4(&h, (struct in_addr *)ip);
pr_err("allowedips random v4 self-test: FAIL\n");
goto free;
}