summaryrefslogtreecommitdiff
path: root/drivers/nvme/target
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-12-14 18:31:21 +0000
committerChristoph Hellwig <hch@lst.de>2018-12-18 17:50:43 +0100
commit66c6afbd7321983be4c4160aff4d79e52af84a60 (patch)
treedd0ffeb07495b1d5a5acffec8d698543768bb9ec /drivers/nvme/target
parentcd19181bf9ad4b7f40f2a4e0355d052109c76529 (diff)
nvmet: fix comparison of a u16 with -1
Currently the u16 req->error_loc is being compared to -1 which will always be false. Fix this by casting -1 to u16 to fix this. Detected by clang: warning: result of comparison of constant -1 with expression of type 'u16' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare] Fixes: 76574f37bf4c ("nvmet: add interface to update error-log page") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/target')
-rw-r--r--drivers/nvme/target/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index cc81d0231587..b9c219c931eb 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -663,7 +663,7 @@ static void nvmet_set_error(struct nvmet_req *req, u16 status)
req->rsp->status = cpu_to_le16(status << 1);
- if (!ctrl || req->error_loc == -1)
+ if (!ctrl || req->error_loc == (u16)-1)
return;
spin_lock_irqsave(&ctrl->error_lock, flags);