summaryrefslogtreecommitdiff
path: root/drivers/scsi/aic7xxx
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2017-09-05 09:51:29 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2017-10-16 22:38:44 -0400
commit287f79653aebfd92a3d30393ef3ca556ec92b84b (patch)
tree210ab08bd0937c6f31f4426aae59dc3891abe50d /drivers/scsi/aic7xxx
parent3e351275655d3c84dc28abf170def9786db5176d (diff)
scsi: nsp32: fix logic bug in error handling
gcc-8 points out a logic error that has existed since the start of the git history: drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] if(((phase & BUSMON_BSY) == 1) || (phase & BUSMON_SEL) == 1) { ^~ Presumably the author intended to check if one of two bits was set, so that's what I'm changing the code to. This will obviously change the behavior of the code, hopefully to do the right thing, but I have not tested this or checked if the new "(phase & BUSMON_BSY) || (phase & BUSMON_SEL)" condition should indeed be treated as a fatal error. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: GOTO Masanori <gotom@debian.or.jp> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/aic7xxx')
0 files changed, 0 insertions, 0 deletions