summaryrefslogtreecommitdiff
path: root/drivers/scsi/am53c974.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2018-10-12 12:41:28 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2018-10-15 22:44:30 -0400
commit664e68bcab5b3e59479494246db980a75822e963 (patch)
tree4a8198cf581442280fc550814072904f7f32260a /drivers/scsi/am53c974.c
parent416c461372b3fe635e5f9a8fbf32f629d3b22c13 (diff)
scsi: ufs: fix integer type usage in uapi header
We get a warning from 'make headers_check' about a newly introduced usage of integer types in the scsi/scsi_bsg_ufs.h uapi header: usr/include/scsi/scsi_bsg_ufs.h:18: found __[us]{8,16,32,64} type without #include <linux/types.h> Aside from the missing linux/types.h inclusion, I also noticed that it uses the wrong types: 'u32' is not available at all in user space, and 'uint32_t' depends on the inclusion of a standard header that we should not include from kernel headers. Change the all to __u32 and similar types here. I also note the usage of '__be32' and '__be16' that seems unfortunate for a user space API. I wonder if it would be better to define the interface in terms of a CPU-endian structure and convert it in kernel space. Fixes: e77044c5a842 ("scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()") Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Avri Altman <avri.altman@wdc.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/am53c974.c')
0 files changed, 0 insertions, 0 deletions