summaryrefslogtreecommitdiff
path: root/drivers/scsi
diff options
context:
space:
mode:
authorKaran Tilak Kumar <kartilak@cisco.com>2025-01-06 14:44:51 -0800
committerMartin K. Petersen <martin.petersen@oracle.com>2025-01-10 18:17:45 -0500
commitbab8551e33f7f5e8743ccb49be41fe3228178e8a (patch)
tree063d903c2d5d88648a0c5249c588342b020c292b /drivers/scsi
parent6cfba11510d6f4d0e863fc0fa939c7a983cf13bd (diff)
scsi: fnic: Remove unnecessary else to fix warning in FDLS FIP
Implement review comments from Martin: Remove unnecessary else from fip.c to fix a warning. Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Reviewed-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250106224451.3597-3-kartilak@cisco.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/fnic/fip.c17
1 files changed, 8 insertions, 9 deletions
diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c
index aaf5f768a9bd..7bb85949033f 100644
--- a/drivers/scsi/fnic/fip.c
+++ b/drivers/scsi/fnic/fip.c
@@ -154,16 +154,15 @@ void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct fip_header *fiph)
vlan->state = FIP_VLAN_AVAIL;
list_add_tail(&vlan->list, &fnic->vlan_list);
break;
- } else {
- FNIC_FIP_DBG(KERN_INFO, fnic->host,
- fnic->fnic_num,
- "Invalid descriptor type(%x) in VLan response\n",
- vlan_desc->fd_desc.fip_dtype);
- /*
- * Note : received a type=2 descriptor here i.e. FIP
- * MAC Address Descriptor
- */
}
+ FNIC_FIP_DBG(KERN_INFO, fnic->host,
+ fnic->fnic_num,
+ "Invalid descriptor type(%x) in VLan response\n",
+ vlan_desc->fd_desc.fip_dtype);
+ /*
+ * Note : received a type=2 descriptor here i.e. FIP
+ * MAC Address Descriptor
+ */
cur_desc += vlan_desc->fd_desc.fip_dlen;
desc_len -= vlan_desc->fd_desc.fip_dlen;
}