diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2015-10-19 13:12:57 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-10-24 19:17:13 -0700 |
| commit | 7c999314efef94be997b762bc22f0be55e139df8 (patch) | |
| tree | 871648ec8e7f23ef96f479159a20cc9c7cb57356 /drivers/staging/comedi/drivers/adl_pci9118.c | |
| parent | 323538b825d4b1eb6c8a9022998822898ab52dff (diff) | |
staging: comedi: adl_pci9118: remove unnecessary check in check_channel_list()
Step 3 of the AI (*do_cmdtest) validates that the cmd->chanlist_len is >= 1. If
it's not the (*do_cmdtest) fails and check_channel_list() is never called. This
This function is also called by the AI (*do_cmd) and the comedi core ensures
that the async command has a valid chanlist. Remove the unnecessary 'n_chan'
check.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/comedi/drivers/adl_pci9118.c')
| -rw-r--r-- | drivers/staging/comedi/drivers/adl_pci9118.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index a7c974423a3e..dcfe5cc08220 100644 --- a/drivers/staging/comedi/drivers/adl_pci9118.c +++ b/drivers/staging/comedi/drivers/adl_pci9118.c @@ -303,11 +303,6 @@ static int check_channel_list(struct comedi_device *dev, struct pci9118_private *devpriv = dev->private; unsigned int i, differencial = 0, bipolar = 0; - /* correct channel and range number check itself comedi/range.c */ - if (n_chan < 1) { - dev_err(dev->class_dev, "range/channel list is empty!\n"); - return 0; - } if ((frontadd + n_chan + backadd) > s->len_chanlist) { dev_err(dev->class_dev, "range/channel list is too long for actual configuration!\n"); |