diff options
| author | Pavel Zemlyanoy <zemlyanoy@ispras.ru> | 2018-08-30 18:13:58 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-09-10 10:09:26 +0200 |
| commit | 196ef5f36071456c47816bfe0a02ce06fd50258b (patch) | |
| tree | 2ef8913e788976ab047b60f8d7c5ed120bdce7fa /drivers/staging/erofs | |
| parent | e84e1ed8cdd750b87d401a99a4de0f40d5d7ff26 (diff) | |
staging: erofs: formatting fix to NULL comparison
This patch does not change the logic, it only
corrects the formatting and checkpatch checks by
to NULL comparison.
The patch fixes 5 checks of type:
"Comparison to NULL could be written".
Signed-off-by: Pavel Zemlyanoy <zemlyanoy@ispras.ru>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/erofs')
| -rw-r--r-- | drivers/staging/erofs/unzip_vle_lz4.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c index f9e6b78c1ee3..54da72a37a39 100644 --- a/drivers/staging/erofs/unzip_vle_lz4.c +++ b/drivers/staging/erofs/unzip_vle_lz4.c @@ -42,8 +42,8 @@ int z_erofs_vle_plain_copy(struct page **compressed_pages, struct page *page = pages[i]; void *dst; - if (page == NULL) { - if (src != NULL) { + if (!page) { + if (src) { if (!mirrored[j]) kunmap_atomic(src); src = NULL; @@ -64,7 +64,7 @@ int z_erofs_vle_plain_copy(struct page **compressed_pages, } if (i) { - if (src == NULL) + if (!src) src = mirrored[i-1] ? percpu_data + (i-1) * PAGE_SIZE : kmap_atomic(compressed_pages[i-1]); @@ -92,7 +92,7 @@ int z_erofs_vle_plain_copy(struct page **compressed_pages, kunmap_atomic(dst); } - if (src != NULL && !mirrored[j]) + if (src && !mirrored[j]) kunmap_atomic(src); preempt_enable(); @@ -136,7 +136,7 @@ int z_erofs_vle_unzip_fast_percpu(struct page **compressed_pages, for (i = 0; i < nr_pages; ++i) { j = min((unsigned int)PAGE_SIZE - pageofs, outlen); - if (pages[i] != NULL) { + if (pages[i]) { if (ret < 0) SetPageError(pages[i]); else if (clusterpages == 1 && pages[i] == compressed_pages[0]) |