diff options
author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2020-03-25 13:20:00 +0100 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-04-14 12:18:37 +0200 |
commit | bfcba38d95a0aed146a958a84a2177af1459eddc (patch) | |
tree | c86b3062f23215c90cf19061b5cf3dc367740d5b /drivers/staging/media/ipu3/TODO | |
parent | 34b7db6fff8d977398234cd6393c620787989e68 (diff) |
media: ov5640: fix use of destroyed mutex
v4l2_ctrl_handler_free() uses hdl->lock, which in ov5640 driver is set
to sensor's own sensor->lock. In ov5640_remove(), the driver destroys the
sensor->lock first, and then calls v4l2_ctrl_handler_free(), resulting
in the use of the destroyed mutex.
Fix this by calling moving the mutex_destroy() to the end of the cleanup
sequence, as there's no need to destroy the mutex as early as possible.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@vger.kernel.org # v4.14+
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging/media/ipu3/TODO')
0 files changed, 0 insertions, 0 deletions