summaryrefslogtreecommitdiff
path: root/drivers/staging/most
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-12-18 11:35:52 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-12-19 08:28:22 +0100
commita86028f8e3eea59517cb47895faad04b6ae8d8e1 (patch)
tree464a91f7ecd2ea51cfecb588f37dfbe16ee8ddc4 /drivers/staging/most
parentd464b7dba1b82dce315af16de88cd6a866306b55 (diff)
staging: most: sound: replace snprintf with strscpy
Using snprintf without a format specifier is potentially risky if the string device_name contains format specifiers. Replace this with the safer and more efficient strscpy. Cleans up clang warning: drivers/staging/most/sound/sound.c:673:41: warning: format string is not a string literal (potentially insecure) [-Wformat-security] Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/most')
-rw-r--r--drivers/staging/most/sound/sound.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
index 29a4c72e6357..79ab3a78c5ec 100644
--- a/drivers/staging/most/sound/sound.c
+++ b/drivers/staging/most/sound/sound.c
@@ -670,7 +670,7 @@ skip_adpt_alloc:
goto err_free_adpt;
pcm->private_data = channel;
- snprintf(pcm->name, sizeof(pcm->name), device_name);
+ strscpy(pcm->name, device_name, sizeof(pcm->name));
snd_pcm_set_ops(pcm, direction, &pcm_ops);
if (create) {