diff options
| author | Larry Finger <Larry.Finger@lwfinger.net> | 2011-09-01 12:23:20 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-09-06 16:35:59 -0700 |
| commit | 2eed3dee92453c1798f0932613b1b66f0763ab2e (patch) | |
| tree | 44ff25dc51f603186073ff85bed655b70fde6e48 /drivers/staging/rtl8192e/rtl819x_TSProc.c | |
| parent | 52a7fb0951b35840a79a5b162fb853b78cec3c09 (diff) | |
staging: rtl8192e: Fix smatch warnings regarding large arrays on stack
Smatch reports the follwing warnings:
CHECK drivers/staging/rtl8192e/rtllib_rx.c
drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn: 'prxbIndicateArray' puts 1024 bytes on stack
CHECK drivers/staging/rtl8192e/rtl819x_TSProc.c
drivers/staging/rtl8192e/rtl819x_TSProc.c +40 RxPktPendingTimeout(9) warn: 'stats_IndicateArray' puts 1024 bytes on stack
CHECK drivers/staging/rtl8192e/r8192E_phy.c
drivers/staging/rtl8192e/r8192E_phy.c +859 rtl8192_phy_SwChnlStepByStep(11) warn: function puts 797 bytes on stack
CHECK drivers/staging/rtl8192e/rtllib_rx.c
drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn: 'prxbIndicateArray' puts 1024 bytes on stack
These are fixed by adding the arrays in question as a union in a struct used
by nearly all routines.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/rtl8192e/rtl819x_TSProc.c')
| -rw-r--r-- | drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c index ccec382cea23..5323a9c7bcad 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -37,7 +37,6 @@ static void RxPktPendingTimeout(unsigned long data) struct rx_reorder_entry *pReorderEntry = NULL; unsigned long flags = 0; - struct rtllib_rxb *stats_IndicateArray[REORDER_WIN_SIZE]; u8 index = 0; bool bPktInBuf = false; @@ -62,7 +61,7 @@ static void RxPktPendingTimeout(unsigned long data) RTLLIB_DEBUG(RTLLIB_DL_REORDER, "%s(): Indicate" " SeqNum: %d\n", __func__, pReorderEntry->SeqNum); - stats_IndicateArray[index] = + ieee->stats_IndicateArray[index] = pReorderEntry->prxb; index++; @@ -85,7 +84,7 @@ static void RxPktPendingTimeout(unsigned long data) flags); return; } - rtllib_indicate_packets(ieee, stats_IndicateArray, index); + rtllib_indicate_packets(ieee, ieee->stats_IndicateArray, index); bPktInBuf = false; } |