diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-04-11 22:21:47 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-14 10:22:03 +0200 |
| commit | 2e85ccf13a724fd6e9bdc50ffe105d68fbbb0ef5 (patch) | |
| tree | bd9d55b895ccef166d6ec4a066cea5f3c28b0c58 /drivers/staging/rtl8723bs | |
| parent | 73bd2eaa8785df85a90212c0841541231cc8e723 (diff) | |
staging: rtl8723bs: ensure cmd is large enough for %4s scanf format
char array cmd is being scanned in using a %4s scanf format
specifier and so cmd must be an array of 5 chars. Increase size
to 5 chars to ensure we don't have an overflow.
Detected with static analysis by cppcheck:
"(error) Width 4 given in format string (no. 1) is larger than
destination buffer 'cmd[4]', use %3s to prevent overflowing it."
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8723bs')
| -rw-r--r-- | drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c index a2011e06d719..8de65e5c80d5 100644 --- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c +++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c @@ -295,7 +295,7 @@ static ssize_t proc_set_cam(struct file *file, const char __user *buffer, size_t struct adapter *adapter; char tmp[32]; - char cmd[4]; + char cmd[5]; u8 id; adapter = (struct adapter *)rtw_netdev_priv(dev); |