summaryrefslogtreecommitdiff
path: root/drivers/usb/phy/phy-am335x-control.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2016-11-01 11:40:25 +0100
committerFelipe Balbi <felipe.balbi@linux.intel.com>2016-11-18 13:54:09 +0200
commit015105b12183556771e111e93f5266851e7c5582 (patch)
tree5caf778885ecb98459347d979bb778b24c39018d /drivers/usb/phy/phy-am335x-control.c
parentf1d3861d63a5d79b8968a02eea1dcb01bb684e62 (diff)
USB: phy: am335x-control: fix device and of_node leaks
Make sure to drop the references taken by of_parse_phandle() and bus_find_device() before returning from am335x_get_phy_control(). Note that there is no guarantee that the devres-managed struct phy_control will be valid for the lifetime of the sibling phy device regardless of this change. Fixes: 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") Acked-by: Bin Liu <b-liu@ti.com> Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/phy/phy-am335x-control.c')
-rw-r--r--drivers/usb/phy/phy-am335x-control.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c
index 42a1afe36a90..5f5f19813fde 100644
--- a/drivers/usb/phy/phy-am335x-control.c
+++ b/drivers/usb/phy/phy-am335x-control.c
@@ -134,10 +134,12 @@ struct phy_control *am335x_get_phy_control(struct device *dev)
return NULL;
dev = bus_find_device(&platform_bus_type, NULL, node, match);
+ of_node_put(node);
if (!dev)
return NULL;
ctrl_usb = dev_get_drvdata(dev);
+ put_device(dev);
if (!ctrl_usb)
return NULL;
return &ctrl_usb->phy_ctrl;