summaryrefslogtreecommitdiff
path: root/drivers/video/backlight/lms283gf05.c
diff options
context:
space:
mode:
authorJingoo Han <jg1.han@samsung.com>2012-12-17 16:01:12 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2012-12-17 17:15:17 -0800
commit1eddd9770f7e809228ae761ecc575f214f571e51 (patch)
tree706b0b70431dccd2262a7de576dc67862492429e /drivers/video/backlight/lms283gf05.c
parent424e06e3da2cbf986d7421f98b90fe5cf4b57be5 (diff)
drivers/video/backlight/lms283gf05.c: use GPIOF_INIT flags when using devm_gpio_request_one()
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below: GPIOF_DIR_OUT (0 << 0) GPIOF_DIR_IN (1 << 0) So, when !pdata->reset_inverted is 1, the gpio pin can be set as input, instead of output. To prevent this problem, GPIOF_INIT flag should be used when using devm_gpio_request_one(). Signed-off-by: Jingoo Han <jg1.han@samsung.com> Cc: Marek Vasut <marex@denx.de> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/backlight/lms283gf05.c')
-rw-r--r--drivers/video/backlight/lms283gf05.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/backlight/lms283gf05.c b/drivers/video/backlight/lms283gf05.c
index 13e24d52887c..55819b384701 100644
--- a/drivers/video/backlight/lms283gf05.c
+++ b/drivers/video/backlight/lms283gf05.c
@@ -159,7 +159,8 @@ static int lms283gf05_probe(struct spi_device *spi)
if (pdata != NULL) {
ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
- GPIOF_DIR_OUT | !pdata->reset_inverted,
+ GPIOF_DIR_OUT | (!pdata->reset_inverted ?
+ GPIOF_INIT_HIGH : GPIOF_INIT_LOW),
"LMS285GF05 RESET");
if (ret)
return ret;