diff options
author | Johannes Berg <johannes.berg@intel.com> | 2023-06-20 13:04:02 +0300 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2023-06-21 14:02:16 +0200 |
commit | 1a528ab1da324d078ec60283c34c17848580df24 (patch) | |
tree | 413a75c9d0ad72ac7320fef4a1edad4210a64777 /drivers/xen/xen-scsiback.c | |
parent | 2db72b8a700943aa54dce0aabe6ff1b72b615162 (diff) |
wifi: iwlwifi: mvm: avoid baid size integer overflow
Roee reported various hard-to-debug crashes with pings in
EHT aggregation scenarios. Enabling KASAN showed that we
access the BAID allocation out of bounds, and looking at
the code a bit shows that since the reorder buffer entry
(struct iwl_mvm_reorder_buf_entry) is 128 bytes if debug
such as lockdep is enabled, then staring from an agg size
512 we overflow the size calculation, and allocate a much
smaller structure than we should, causing slab corruption
once we initialize this.
Fix this by simply using u32 instead of u16.
Reported-by: Roee Goldfiner <roee.h.goldfiner@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230620125813.f428c856030d.I2c2bb808e945adb71bc15f5b2bac2d8957ea90eb@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/xen/xen-scsiback.c')
0 files changed, 0 insertions, 0 deletions