summaryrefslogtreecommitdiff
path: root/fs/super.c
diff options
context:
space:
mode:
authorChristian Brauner <brauner@kernel.org>2023-11-27 12:51:31 +0100
committerChristian Brauner <brauner@kernel.org>2023-11-28 19:15:37 +0100
commit63513f8574c5ef481cd6a85b8c71f6f40f7d7957 (patch)
tree7209db69d6138c50f5a85e7500491e4f70288fa2 /fs/super.c
parentb30850c58b5b9b7008eb6fc4a65bfb003a0714a7 (diff)
super: don't bother with WARN_ON_ONCE()
We hold our own active reference and we've checked it above. Link: https://lore.kernel.org/r/20231127-vfs-super-massage-wait-v1-2-9ab277bfd01a@kernel.org Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/super.c')
-rw-r--r--fs/super.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/super.c b/fs/super.c
index 9cfe9c379c3f..1745cf7ea005 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -2067,10 +2067,7 @@ retry:
/* Release s_umount to preserve sb_start_write -> s_umount ordering */
super_unlock_excl(sb);
sb_wait_write(sb, SB_FREEZE_WRITE);
- if (!super_lock_excl(sb)) {
- WARN_ON_ONCE("Dying superblock while freezing!");
- return -EINVAL;
- }
+ __super_lock_excl(sb);
/* Now we go and block page faults... */
sb->s_writers.frozen = SB_FREEZE_PAGEFAULT;