summaryrefslogtreecommitdiff
path: root/include/linux/phy_led_triggers.h
diff options
context:
space:
mode:
authorJiakai Luo <jkluo@hust.edu.cn>2023-04-22 06:34:06 -0700
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2023-05-13 17:54:57 +0100
commit27b2ed5b6d53cd62fc61c3f259ae52f5cac23b66 (patch)
tree25d1106c43c530b9bd066131a228b258186818a4 /include/linux/phy_led_triggers.h
parent28f73ded19d403697f87473c9b85a27eb8ed9cf2 (diff)
iio: adc: mxs-lradc: fix the order of two cleanup operations
Smatch reports: drivers/iio/adc/mxs-lradc-adc.c:766 mxs_lradc_adc_probe() warn: missing unwind goto? the order of three init operation: 1.mxs_lradc_adc_trigger_init 2.iio_triggered_buffer_setup 3.mxs_lradc_adc_hw_init thus, the order of three cleanup operation should be: 1.mxs_lradc_adc_hw_stop 2.iio_triggered_buffer_cleanup 3.mxs_lradc_adc_trigger_remove we exchange the order of two cleanup operations, introducing the following differences: 1.if mxs_lradc_adc_trigger_init fails, returns directly; 2.if trigger_init succeeds but iio_triggered_buffer_setup fails, goto err_trig and remove the trigger. In addition, we also reorder the unwind that goes on in the remove() callback to match the new ordering. Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver") Signed-off-by: Jiakai Luo <jkluo@hust.edu.cn> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> Link: https://lore.kernel.org/r/20230422133407.72908-1-jkluo@hust.edu.cn Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'include/linux/phy_led_triggers.h')
0 files changed, 0 insertions, 0 deletions