diff options
| author | Hans Verkuil <hansverk@cisco.com> | 2018-05-11 05:32:24 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-05-28 16:31:44 -0400 |
| commit | 73a110623e7b7592defea69f028cccae495d69a4 (patch) | |
| tree | 9b1c21779d0317c9d18715cb9ce7197e8f2e0117 /include/media/v4l2-dev.h | |
| parent | eba09b5b3dfb1b79db4428b6f379f68db4b62056 (diff) | |
media: v4l2-core: push taking ioctl mutex down to ioctl handler
The ioctl serialization mutex (vdev->lock or q->lock for vb2 queues)
was taken at the highest level in v4l2-dev.c. This prevents more
fine-grained locking since at that level we cannot examine the ioctl
arguments, we can only do that after video_usercopy is called.
So push the locking down to __video_do_ioctl() and subdev_do_ioctl_lock().
This also allows us to make a few functions in v4l2-ioctl.c static and
video_usercopy() is no longer exported.
The locking scheme is not changed by this patch, just pushed down.
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'include/media/v4l2-dev.h')
| -rw-r--r-- | include/media/v4l2-dev.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/include/media/v4l2-dev.h b/include/media/v4l2-dev.h index 30423aefe7c5..456ac13eca1d 100644 --- a/include/media/v4l2-dev.h +++ b/include/media/v4l2-dev.h @@ -436,15 +436,6 @@ void video_device_release(struct video_device *vdev); void video_device_release_empty(struct video_device *vdev); /** - * v4l2_is_known_ioctl - Checks if a given cmd is a known V4L ioctl - * - * @cmd: ioctl command - * - * returns true if cmd is a known V4L2 ioctl - */ -bool v4l2_is_known_ioctl(unsigned int cmd); - -/** * v4l2_disable_ioctl- mark that a given command isn't implemented. * shouldn't use core locking * |