summaryrefslogtreecommitdiff
path: root/kernel/irq/resend.c
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@intel.com>2021-11-08 08:48:14 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2021-11-16 19:42:31 -0500
commit886fe2915cce6658b0fc19e64b82879325de61ea (patch)
tree18d20c876f5eb81b043cb3024d49f24fbbabc99d /kernel/irq/resend.c
parent4edd8cd4e86dd3047e5294bbefcc0a08f66a430f (diff)
scsi: ufs: core: Fix task management completion timeout race
__ufshcd_issue_tm_cmd() clears req->end_io_data after timing out, which races with the completion function ufshcd_tmc_handler() which expects req->end_io_data to have a value. Note __ufshcd_issue_tm_cmd() and ufshcd_tmc_handler() are already synchronized using hba->tmf_rqs and hba->outstanding_tasks under the host_lock spinlock. It is also not necessary (nor typical) to clear req->end_io_data because the block layer does it before allocating out requests e.g. via blk_get_request(). So fix by not clearing it. Link: https://lore.kernel.org/r/20211108064815.569494-2-adrian.hunter@intel.com Fixes: f5ef336fd2e4 ("scsi: ufs: core: Fix task management completion") Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'kernel/irq/resend.c')
0 files changed, 0 insertions, 0 deletions