diff options
author | John Ogness <john.ogness@linutronix.de> | 2023-07-17 21:52:04 +0206 |
---|---|---|
committer | Petr Mladek <pmladek@suse.com> | 2023-07-20 13:06:22 +0200 |
commit | eacb04ff3c5b8662a65f380ae450250698448cff (patch) | |
tree | f1a65dc46f0fd01d7473fbd8ea58d48e60edcd5a /kernel/printk/braille.c | |
parent | 51a1d258e50e03a0216bf42b6af9ff34ec402ac1 (diff) |
printk: Do not take console lock for console_flush_on_panic()
Currently console_flush_on_panic() will attempt to acquire the
console lock when flushing the buffer on panic. If it fails to
acquire the lock, it continues anyway because this is the last
chance to get any pending records printed.
The reason why the console lock was attempted at all was to
prevent any other CPUs from acquiring the console lock for
printing while the panic CPU was printing. But as of the
previous commit, non-panic CPUs will no longer attempt to
acquire the console lock in a panic situation. Therefore it is
no longer strictly necessary for a panic CPU to acquire the
console lock.
Avoiding taking the console lock when flushing in panic has
the additional benefit of avoiding possible deadlocks due to
semaphore usage in NMI context (semaphores are not NMI-safe)
and avoiding possible deadlocks if another CPU accesses the
semaphore and is stopped while holding one of the semaphore's
internal spinlocks.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20230717194607.145135-5-john.ogness@linutronix.de
Diffstat (limited to 'kernel/printk/braille.c')
0 files changed, 0 insertions, 0 deletions