diff options
| author | Waiman Long <longman@redhat.com> | 2024-02-08 11:10:14 -0500 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2024-02-08 09:23:38 -1000 |
| commit | 49584bb8ddbe8bcfc276c2d7dd3c8890f45f5970 (patch) | |
| tree | b98acf9d9e77c10012095c7410feaf9629275c9e /kernel/workqueue.c | |
| parent | d64f2fa064f8866802e23c8ec95d9d1f601480ee (diff) | |
workqueue: Bind unbound workqueue rescuer to wq_unbound_cpumask
Commit 85f0ab43f9de ("kernel/workqueue: Bind rescuer to unbound
cpumask for WQ_UNBOUND") modified init_rescuer() to bind rescuer of
an unbound workqueue to the cpumask in wq->unbound_attrs. However
unbound_attrs->cpumask's of all workqueues are initialized to
cpu_possible_mask and will only be changed if it has the WQ_SYSFS flag
to expose a cpumask sysfs file to be written by users. So this patch
doesn't achieve what it is intended to do.
If an unbound workqueue is created after wq_unbound_cpumask is modified
and there is no more unbound cpumask update after that, the unbound
rescuer will be bound to all CPUs unless the workqueue is created
with the WQ_SYSFS flag and a user explicitly modified its cpumask
sysfs file. Fix this problem by binding directly to wq_unbound_cpumask
in init_rescuer().
Fixes: 85f0ab43f9de ("kernel/workqueue: Bind rescuer to unbound cpumask for WQ_UNBOUND")
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index a24c7cfb80b4..cd2c6edc5c66 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5299,7 +5299,7 @@ static int init_rescuer(struct workqueue_struct *wq) wq->rescuer = rescuer; if (wq->flags & WQ_UNBOUND) - kthread_bind_mask(rescuer->task, wq->unbound_attrs->cpumask); + kthread_bind_mask(rescuer->task, wq_unbound_cpumask); else kthread_bind_mask(rescuer->task, cpu_possible_mask); wake_up_process(rescuer->task); |