diff options
author | Bob Peterson <rpeterso@redhat.com> | 2019-11-19 11:40:46 -0500 |
---|---|---|
committer | Andreas Gruenbacher <agruenba@redhat.com> | 2019-11-19 21:02:01 +0100 |
commit | 2c47c1be51fbded1f7baa2ceaed90f97932f79be (patch) | |
tree | dd4a9ef55e8788f8ca113ec03aca7d0a34d78870 /lib/test_bitmap.c | |
parent | d99724c3c36ae73ed3908f5e3f2d103a48cd9ad0 (diff) |
gfs2: clean up iopen glock mess in gfs2_create_inode
Before this patch, gfs2_create_inode had a use-after-free for the
iopen glock in some error paths because it did this:
gfs2_glock_put(io_gl);
fail_gunlock2:
if (io_gl)
clear_bit(GLF_INODE_CREATING, &io_gl->gl_flags);
In some cases, the io_gl was used for create and only had one
reference, so the glock might be freed before the clear_bit().
This patch tries to straighten it out by only jumping to the
error paths where iopen is properly set, and moving the
gfs2_glock_put after the clear_bit.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'lib/test_bitmap.c')
0 files changed, 0 insertions, 0 deletions