diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-02-13 06:32:39 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-02-14 11:20:13 +0000 |
| commit | 004d138364fd10dd5ff8ceb54cfdc2d792a7b338 (patch) | |
| tree | 19491864f7a5306175afb03f896047725ffe281f /net/core/rtnetlink.c | |
| parent | c7d52737e7ebd31cc5fef46380d94b58becf9479 (diff) | |
net-sysfs: convert dev->operstate reads to lockless ones
operstate_show() can omit dev_base_lock acquisition only
to read dev->operstate.
Annotate accesses to dev->operstate.
Writers still acquire dev_base_lock for mutual exclusion.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/rtnetlink.c')
| -rw-r--r-- | net/core/rtnetlink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index fd47a4422a51..43d92de8601c 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -866,9 +866,9 @@ static void set_operstate(struct net_device *dev, unsigned char transition) break; } - if (dev->operstate != operstate) { + if (READ_ONCE(dev->operstate) != operstate) { write_lock(&dev_base_lock); - dev->operstate = operstate; + WRITE_ONCE(dev->operstate, operstate); write_unlock(&dev_base_lock); netdev_state_change(dev); } |